This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Removed linear gradient heap allocation for color conversions between dart and display list #57108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
changed the title
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
don't the other gradient types need these changes too?
| } | ||
| } | ||
|
|
||
| class DlScalerToDlColorIt { |
Contributor
There was a problem hiding this comment.
Til how iterators work in C++.
Maybe DlColorConversionIterator?
Member
Author
There was a problem hiding this comment.
Til how iterators work in C++.
Yea, just think of using operator overloading to make a class work like a pointer and use templates to accept anything that works like a pointer.
Maybe DlColorConversionIterator?
done
flar
reviewed
Dec 11, 2024
Member
Author
yep, they'll happen in different PRs |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2024
… between dart and display list (flutter/engine#57108)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2024
flutter/engine@7941d78...3cdd841 2024-12-11 jonahwilliams@google.com [Impeller] set UniformBlockBinding once. (flutter/engine#57094) 2024-12-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5taAI9-tnFN84ZJvr... to HJ57Y3zxqDamI8qkY... (flutter/engine#57125) 2024-12-11 30870216+gaaclarke@users.noreply.github.com Removed linear gradient heap allocation for color conversions between dart and display list (flutter/engine#57108) 2024-12-11 jason-simmons@users.noreply.github.com Dispose pictures created in HtmlViewEmbedder.submitFrame (flutter/engine#57102) 2024-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 4789a86f4d3f to be9c98daf9df (1 revision) (flutter/engine#57124) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 5taAI9-tnFN8 to HJ57Y3zxqDam If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
… dart and display list (flutter/engine#57108) issue: flutter#154650 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#154650
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.